Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: chrome/common/extensions/docs/server2/reference_resolver_test.py

Issue 80183002: Correct $ref links in extensions documentation server relative location. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Feedback Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/reference_resolver_test.py
diff --git a/chrome/common/extensions/docs/server2/reference_resolver_test.py b/chrome/common/extensions/docs/server2/reference_resolver_test.py
index 3cbcea32f06bf71ea988c9c7c6e648b3e4340aa0..b20c73fb919a9b0b6a11fb46f9fc5c170bc67cca 100755
--- a/chrome/common/extensions/docs/server2/reference_resolver_test.py
+++ b/chrome/common/extensions/docs/server2/reference_resolver_test.py
@@ -12,7 +12,6 @@ from file_system import FileNotFoundError
from reference_resolver import ReferenceResolver
from test_object_store import TestObjectStore
-
not at google - send to devlin 2013/11/22 20:16:10 ditto blank line
benwells 2013/11/27 07:28:31 Done.
class FakeAPIDataSource(object):
def __init__(self, json_data):
self._json = json_data
@@ -169,6 +168,16 @@ class APIDataSourceTest(unittest.TestCase):
'<a href="bar.html#type-bon">bar.bon</a>.',
resolver.ResolveAllLinks('$ref:bar.bon.',
namespace='baz'))
+
+ # If a request is provided it should construct an appropriate relative link.
+ self.assertEqual(
+ 'Hi <a href="../../bar.bon.html#property-bar_bon_p3">bar_bon_p3</a>, '
+ '<a href="../../bar.bon.html#property-bar_bon_p3">Bon Bon</a>, '
+ '<a href="../../bar.bon.html#property-bar_bon_p3">bar_bon_p3</a>',
+ resolver.ResolveAllLinks(
+ 'Hi $ref:bar_bon_p3, $ref:[bar_bon_p3 Bon Bon], $ref:bar_bon_p3',
+ requestPath='big/long/path/bar.html',
+ namespace='bar.bon'))
if __name__ == '__main__':
unittest.main()

Powered by Google App Engine
This is Rietveld 408576698