chrome/common/extensions/docs/server2/intro_data_source.py - Issue 80183002: Correct $ref links in extensions documentation server relative location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/intro_data_source.py

Issue 80183002: Correct $ref links in extensions documentation server relative location. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Feedback Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/common/extensions/docs/server2/reference_resolver.py » ('j') | chrome/common/extensions/docs/server2/reference_resolver.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/intro_data_source.py

diff --git a/chrome/common/extensions/docs/server2/intro_data_source.py b/chrome/common/extensions/docs/server2/intro_data_source.py

index 161373414ab1ebb2983d8915188e4f73e6672ad0..688362a248439b31f63b8ebc98dbe39fbb4877a4 100644

--- a/chrome/common/extensions/docs/server2/intro_data_source.py

+++ b/chrome/common/extensions/docs/server2/intro_data_source.py

@@ -94,8 +94,11 @@ class IntroDataSource(DataSource):

def _MakeIntro(self, intro_path, intro):

# Guess the name of the API from the path to the intro.

api_name = os.path.splitext(intro_path.split('/')[-1])[0]

+ request_path = ''

+ if self._request:

+ request_path = self._request.path

not at google - send to devlin 2013/11/22 20:16:10 nit: ternary: request_path = self._request.path i

benwells 2013/11/25 01:12:37 I was thinking it might be better to make sure tha

benwells 2013/11/27 07:28:31 Removed the code by making sure self._request was

intro_with_links = self._ref_resolver.ResolveAllLinks(

- intro, namespace=api_name)

+ intro, requestPath=request_path, namespace=api_name)

not at google - send to devlin 2013/11/22 20:16:10 python style requires request_path not requestPath

benwells 2013/11/27 07:28:31 Done.

# TODO(kalman): In order to pick up every header tag, and therefore make a

# complete TOC, the render context of the Handlebar needs to be passed

« no previous file with comments | « no previous file | chrome/common/extensions/docs/server2/reference_resolver.py » ('j') | chrome/common/extensions/docs/server2/reference_resolver.py » ('J')