Correct $ref links in extensions documentation server relative location.

chrome/common/extensions/docs/server2/reference_resolver_test.py

Index: chrome/common/extensions/docs/server2/reference_resolver_test.py
diff --git a/chrome/common/extensions/docs/server2/reference_resolver_test.py b/chrome/common/extensions/docs/server2/reference_resolver_test.py
index 3cbcea32f06bf71ea988c9c7c6e648b3e4340aa0..ea32488c03f9e2048a9ce361327cab57de719342 100755
--- a/chrome/common/extensions/docs/server2/reference_resolver_test.py
+++ b/chrome/common/extensions/docs/server2/reference_resolver_test.py
@@ -12,7 +12,6 @@ from file_system import FileNotFoundError
 from reference_resolver import ReferenceResolver
 from test_object_store import TestObjectStore
 
-
 class FakeAPIDataSource(object):
   def __init__(self, json_data):
     self._json = json_data
@@ -146,29 +145,47 @@ class APIDataSourceTest(unittest.TestCase):
             '<a href="bar.bon.html#property-bar_bon_p3">bar_bon_p3</a>',
         resolver.ResolveAllLinks(
             'Hello $ref:bar_bon_p3, $ref:[bar_bon_p3 Bon Bon], $ref:bar_bon_p3',
+            None,
             namespace='bar.bon'))
     self.assertEqual(
         'I like <a href="bar.html#property-bar_t1-bar_t1_p1">food</a>.',
         resolver.ResolveAllLinks('I like $ref:[bar.bar_p3.bar_t1_p1 food].',
+                                 None,
                                  namespace='foo'))
     self.assertEqual(
         'Ref <a href="foo.html">It\'s foo!</a>',
-        resolver.ResolveAllLinks('Ref $ref:[foo It\'s foo!]', namespace='bar'))
+        resolver.ResolveAllLinks('Ref $ref:[foo It\'s foo!]', None, namespace='bar'))
     self.assertEqual(
         'Ref <a href="bar.html#type-bon">Bon</a>',
-        resolver.ResolveAllLinks('Ref $ref:[bar.bon Bon]', namespace='bar'))
+        resolver.ResolveAllLinks('Ref $ref:[bar.bon Bon]', None, namespace='bar'))
 
     # Different kinds of whitespace can be significant inside <pre> tags.
     self.assertEqual(
         '<pre><a href="bar.html#type-bon">bar.bon</a>({\nkey: value})',
         resolver.ResolveAllLinks('<pre>$ref:[bar.bon]({\nkey: value})',
+                                 None,
                                  namespace='baz'))
 
     # Allow bare "$ref:foo.bar." at the end of a string.
     self.assertEqual(
         '<a href="bar.html#type-bon">bar.bon</a>.',
         resolver.ResolveAllLinks('$ref:bar.bon.',
+                                 None,

[not at google - send to devlin, 2013/11/21 05:26:50]

if the request/path/prefix whatever is optional then you don't need to add None
everywhere

[benwells, 2013/11/22 05:44:01]

Done.

                                  namespace='baz'))
+    
+    # If a request is provided it should construct an approapriate relative link.

[not at google - send to devlin, 2013/11/21 05:26:50]

appropriate

[benwells, 2013/11/22 05:44:01]

Done.

+    class FakeRequest(object):
+      pass            
+    request = FakeRequest()

[not at google - send to devlin, 2013/11/21 05:26:50]

use
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...
though if you only pass in the path or prefix it's unnecessary anyway

[benwells, 2013/11/22 05:44:01]

Done.

+    request.path = 'foo/big/long/path/bar.html'
+    self.assertEqual(
+        'Hello <a href="../../../bar.bon.html#property-bar_bon_p3">bar_bon_p3</a>, '
+            '<a href="../../../bar.bon.html#property-bar_bon_p3">Bon Bon</a>, '
+            '<a href="../../../bar.bon.html#property-bar_bon_p3">bar_bon_p3</a>',

[not at google - send to devlin, 2013/11/21 05:26:50]

keep < 80 chars

[benwells, 2013/11/22 05:44:01]

Done.

+        resolver.ResolveAllLinks(
+            'Hello $ref:bar_bon_p3, $ref:[bar_bon_p3 Bon Bon], $ref:bar_bon_p3',
+            request,
+            namespace='bar.bon'))    
 
 if __name__ == '__main__':
   unittest.main()