Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 801813002: Using PropertyKind in transitions instead of PropertyType. (Closed)

Created:
6 years ago by Igor Sheludko
Modified:
6 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Using PropertyKind in transitions instead of PropertyType.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -64 lines) Patch
M src/objects.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/objects-inl.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/transitions.h View 3 chunks +8 lines, -9 lines 0 comments Download
M src/transitions.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M src/transitions-inl.h View 2 chunks +7 lines, -12 lines 0 comments Download
M test/cctest/test-transitions.cc View 7 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Igor Sheludko
PTAL
6 years ago (2014-12-12 13:12:26 UTC) #2
Jakob Kummerow
lgtm
6 years ago (2014-12-12 14:59:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801813002/1
6 years ago (2014-12-12 15:00:32 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-12 15:27:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698