Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 801803002: Add SSLClientSocket::SerializeNextProtos unittest. (Closed)

Created:
6 years ago by Bence
Modified:
6 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SSLClientSocket::SerializeNextProtos unittest. BUG= Committed: https://crrev.com/90c006969d775809dc32415f3b47f41b0dcbfe65 Cr-Commit-Position: refs/heads/master@{#308098}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M net/socket/ssl_client_socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 1 chunk +27 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
Bence
Ryan: PTAL. Thanks.
6 years ago (2014-12-12 13:53:05 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/801803002/diff/1/net/socket/ssl_client_socket_unittest.cc File net/socket/ssl_client_socket_unittest.cc (right): https://codereview.chromium.org/801803002/diff/1/net/socket/ssl_client_socket_unittest.cc#newcode2378 net/socket/ssl_client_socket_unittest.cc:2378: EXPECT_EQ('1', serialized[17]); Could you do something like EXPECT_EQ("\x08http/1.1\x08spdy/3.1", ...
6 years ago (2014-12-12 15:12:12 UTC) #3
Bence
Thanks. https://codereview.chromium.org/801803002/diff/1/net/socket/ssl_client_socket_unittest.cc File net/socket/ssl_client_socket_unittest.cc (right): https://codereview.chromium.org/801803002/diff/1/net/socket/ssl_client_socket_unittest.cc#newcode2378 net/socket/ssl_client_socket_unittest.cc:2378: EXPECT_EQ('1', serialized[17]); On 2014/12/12 15:12:12, Ryan Hamilton wrote: ...
6 years ago (2014-12-12 15:40:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801803002/1
6 years ago (2014-12-12 15:41:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 16:26:15 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-12 16:27:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90c006969d775809dc32415f3b47f41b0dcbfe65
Cr-Commit-Position: refs/heads/master@{#308098}

Powered by Google App Engine
This is Rietveld 408576698