Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: LayoutTests/crypto/ecdsa-generateKey-parseAlgorithm-failures.html

Issue 801793003: Improve LayoutTest output for Errors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/crypto/ecdsa-generateKey-parseAlgorithm-failures.html
diff --git a/LayoutTests/crypto/ecdsa-generateKey-parseAlgorithm-failures.html b/LayoutTests/crypto/ecdsa-generateKey-parseAlgorithm-failures.html
index 6b65123a6d817c1761d6a964735457df5e239643..a90f3ed5730d6a96829add797b650ee187356828 100644
--- a/LayoutTests/crypto/ecdsa-generateKey-parseAlgorithm-failures.html
+++ b/LayoutTests/crypto/ecdsa-generateKey-parseAlgorithm-failures.html
@@ -16,22 +16,22 @@ extractable = true;
keyUsages = ['sign', 'verify'];
Promise.resolve(null).then(function() {
- // Missing curve name.
+ debug("\ngenerateKey() without namedCurve...");
return crypto.subtle.generateKey({name: 'ECDSA'}, extractable , keyUsages);
}).then(failAndFinishJSTest, function(result) {
logError(result);
- // Named curve is invalid (an integer when it should be a string).
+ debug("\ngenerateKey() with namedCurve that is an integer...");
return crypto.subtle.generateKey({name: 'ECDSA', namedCurve: -1}, extractable , keyUsages);
}).then(failAndFinishJSTest, function(result) {
logError(result);
- // Named curve is unrecognized (lower case when it should be upper case)
+ debug("\ngenerateKey() with namedCurve 'p-256' that contains lower case character 'p'...");
return crypto.subtle.generateKey({name: 'ECDSA', namedCurve: 'p-256'}, extractable , keyUsages);
}).then(failAndFinishJSTest, function(result) {
logError(result);
- // Named curve is unrecognized (contains some trailing characters).
+ debug("\ngenerateKey() with namedCurve 'P-256aa' that contains trailing characters 'aa'...");
return crypto.subtle.generateKey({name: 'ECDSA', namedCurve: 'P-256aa'}, extractable , keyUsages);
}).then(failAndFinishJSTest, function(result) {
logError(result);

Powered by Google App Engine
This is Rietveld 408576698