Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: LayoutTests/crypto/aes-cbc-parseAlgorithm-failures.html

Issue 801793003: Improve LayoutTest output for Errors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/crypto/aes-cbc-parseAlgorithm-failures.html
diff --git a/LayoutTests/crypto/aes-cbc-parseAlgorithm-failures.html b/LayoutTests/crypto/aes-cbc-parseAlgorithm-failures.html
index 4396f831449695a71f031dcd88f131f07b1635c0..09bdd0d234d3322931542129b20ba84c2ad64034 100644
--- a/LayoutTests/crypto/aes-cbc-parseAlgorithm-failures.html
+++ b/LayoutTests/crypto/aes-cbc-parseAlgorithm-failures.html
@@ -22,31 +22,37 @@ Promise.resolve(null).then(function(result) {
var extractable = false;
var algorithm = {name: 'aes-cbc'};
+ debug('\nImporting AES-CBC key...');
return crypto.subtle.importKey('raw', keyData, algorithm, extractable, usages);
}).then(function(result) {
key = result;
// Bad iv
+ debug('\nencrypt() with iv that is null...');
return crypto.subtle.encrypt({name: 'AES-CBC', iv: null}, key, data);
}).then(failAndFinishJSTest, function(result) {
logError(result);
// Missing iv
+ debug('\nencrypt() without iv...');
return crypto.subtle.decrypt({name: 'AES-CBC'}, key, data);
}).then(failAndFinishJSTest, function(result) {
logError(result);
// iv is not a buffer
+ debug('\nencrypt() with iv that is a number...');
return crypto.subtle.encrypt({name: 'AES-CBC', iv: 3}, key, data);
}).then(failAndFinishJSTest, function(result) {
logError(result);
// iv is too short
+ debug('\nencrypt() with iv that is of 0 byte...');
eroman 2014/12/12 19:37:01 "encrypt() with an iv that is empty" or "encrypt()
jww 2014/12/12 19:55:24 nit: "0 byte" -> "0 bytes"
Paritosh Kumar 2014/12/15 08:21:26 Done.
Paritosh Kumar 2014/12/15 08:21:26 Done.
return crypto.subtle.encrypt({name: 'AES-CBC', iv: new Uint8Array(0)}, key, data);
}).then(failAndFinishJSTest, function(result) {
logError(result);
// iv is longer than expected
+ debug('\nencrypt() with iv that is of 17 byte...');
eroman 2014/12/12 19:37:01 encrypt() with an iv containing 17 bytes
jww 2014/12/12 19:55:24 nit: "17 byte" -> "17 bytes"
Paritosh Kumar 2014/12/15 08:21:26 Done.
Paritosh Kumar 2014/12/15 08:21:26 Done.
return crypto.subtle.encrypt({name: 'AES-CBC', iv: new ArrayBuffer(17)}, key, data);
}).then(failAndFinishJSTest, function(result) {
logError(result);

Powered by Google App Engine
This is Rietveld 408576698