Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 801753002: infobars: Fix static initializer created in r308046. (Closed)

Created:
6 years ago by Lei Zhang
Modified:
6 years ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

infobars: Fix static initializer created in r308046. BUG=382924 TBR=pkasting@chromium.org Committed: https://crrev.com/75407005f983a45d76f1e70d1a3892e34cec9485 Cr-Commit-Position: refs/heads/master@{#308076}

Patch Set 1 #

Patch Set 2 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/infobar_container_delegate.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
TBR
6 years ago (2014-12-12 10:18:38 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-12 10:45:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801753002/20001
6 years ago (2014-12-12 10:45:39 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 14:40:21 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/75407005f983a45d76f1e70d1a3892e34cec9485 Cr-Commit-Position: refs/heads/master@{#308076}
6 years ago (2014-12-12 14:41:38 UTC) #7
Peter Kasting
That's strange, why did the old code create a static initializer? It's sort of sad ...
6 years ago (2014-12-12 19:09:32 UTC) #8
Peter Kasting
6 years ago (2014-12-12 19:11:35 UTC) #9
Message was sent while issue was closed.
On 2014/12/12 19:09:32, Peter Kasting wrote:
> That's strange, why did the old code create a static initializer?  It's sort
of
> sad that we need this patch, since the #ifs are much uglier.

Never mind, I understand why.  Lame.  Thanks for the fix.

Powered by Google App Engine
This is Rietveld 408576698