Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 8017001: Fix for gdbjit. (Closed)

Created:
9 years, 3 months ago by Yang
Modified:
9 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Fix for gdbjit.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/mark-compact.cc View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Yang
NewGC broke the compile option "gdbjit=on" due to undefined variable. This is my shot at ...
9 years, 3 months ago (2011-09-23 09:23:15 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 3 months ago (2011-09-23 09:27:55 UTC) #2
atm gdbjit is broken because it will not receive code delete events
(reportdeleteifneeded is not called by codespace sweeper). can you fix that as
well?

http://codereview.chromium.org/8017001/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/8017001/diff/1/src/mark-compact.cc#newcode490
src/mark-compact.cc:490: gdbjit = true;
lets instead do 

never_compact = true;
sweep_precise_ = true; 

here.

Powered by Google App Engine
This is Rietveld 408576698