Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 801693003: Fill SkRRect::fType proactively. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fill SkRRect::fType proactively. I found no external mentions of SkRRect::kUnknown_Type. Motivating race found by TSAN: http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot/builds/48/steps/dm/logs/stdio BUG=skia: Committed: https://skia.googlesource.com/skia/+/8aacf2085673f6302a43d590d4d2890789b87192

Patch Set 1 #

Patch Set 2 : validate at end #

Patch Set 3 : debug only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -27 lines) Patch
M include/core/SkRRect.h View 3 chunks +2 lines, -10 lines 0 comments Download
M src/core/SkRRect.cpp View 1 2 3 chunks +8 lines, -9 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/utils/SkLua.cpp View 4 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein
6 years ago (2014-12-18 21:05:45 UTC) #2
reed1
lgtm... rob, you think we can afford to always compute this up-front?
6 years ago (2014-12-18 21:11:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801693003/40001
6 years ago (2014-12-18 21:14:31 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-18 21:14:32 UTC) #8
robertphillips
lgtm - it looks like there's no way we can do anything with the RR ...
6 years ago (2014-12-18 21:28:59 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/8aacf2085673f6302a43d590d4d2890789b87192
6 years ago (2014-12-18 21:30:10 UTC) #10
mtklein
6 years ago (2014-12-18 21:37:30 UTC) #11
Message was sent while issue was closed.
On 2014/12/18 21:28:59, robertphillips wrote:
> it looks like there's no way we can do anything with the RR w/o computing
> the type so it shouldn't slow us down.

Agreed.

Powered by Google App Engine
This is Rietveld 408576698