Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 801643009: Remove <video controls> hack. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
eseidel, ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove <video controls> hack. insertedInto and removedFrom should always be paired, there's no reason to track this state separately when updating the childShadowRoot bits. I also removed the inDocument() checks from ShadowRoot::insertedInto and removed from since distribution happens in detached subtrees too. It appears that while they were wrong, it didn't matter because the state was only used together with containsContentElements() in a check of the form: if (!containsShadowRoots() && !containsContentElements()) return; which meant that while the containsShadowRoots bit might be wrong false incorrectly, the containsContentElements is always correct so we'd never take the early out incorrectly. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ac37e80d199a945bf043146bdea8cab21b6216ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M sky/engine/core/dom/shadow/ShadowRoot.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.cpp View 2 chunks +6 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years ago (2014-12-18 00:39:15 UTC) #2
eseidel
lgtm
6 years ago (2014-12-18 00:43:56 UTC) #3
esprehn
6 years ago (2014-12-18 01:20:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ac37e80d199a945bf043146bdea8cab21b6216ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698