Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Issue 801643006: Enable chrome.gyp:browser_ui on iOS (Closed)

Created:
6 years ago by stuartmorgan
Modified:
6 years ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable chrome.gyp:browser_ui on iOS Re-enabled building of the browser_ui target on iOS (lost when unit_tests was turned down). As with browser, removes non_android sources and puts everything in non_mobile_sources. See also https://codereview.chromium.org/785233002 BUG=432994 Committed: https://crrev.com/bf18dfa875cc92e107907083196f6de56cb85a34 Cr-Commit-Position: refs/heads/master@{#308448}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 13 chunks +27 lines, -25 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
stuartmorgan
6 years ago (2014-12-15 19:56:50 UTC) #2
Nico
The sources! bit is a bit icky, but lgtm https://codereview.chromium.org/801643006/diff/1/chrome/chrome_browser_ui.gypi File chrome/chrome_browser_ui.gypi (right): https://codereview.chromium.org/801643006/diff/1/chrome/chrome_browser_ui.gypi#newcode1326 chrome/chrome_browser_ui.gypi:1326: ...
6 years ago (2014-12-15 20:50:54 UTC) #3
stuartmorgan
On 2014/12/15 20:50:54, Nico wrote: > The sources! bit is a bit icky, but lgtm ...
6 years ago (2014-12-15 21:13:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801643006/1
6 years ago (2014-12-15 21:15:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 22:48:11 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-15 22:49:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf18dfa875cc92e107907083196f6de56cb85a34
Cr-Commit-Position: refs/heads/master@{#308448}

Powered by Google App Engine
This is Rietveld 408576698