Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 801643005: Use IDMap in PushProvider. (Closed)

Created:
6 years ago by mlamouri (slow - plz ping)
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use IDMap in PushProvider. BUG=None Committed: https://crrev.com/76e6d7f6c874d06410f56a10d20266c89e25e438 Cr-Commit-Position: refs/heads/master@{#308405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -30 lines) Patch
M content/child/push_messaging/push_provider.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/child/push_messaging/push_provider.cc View 4 chunks +22 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mlamouri (slow - plz ping)
6 years ago (2014-12-15 17:56:44 UTC) #2
Michael van Ouwerkerk
Nice :-) lgtm
6 years ago (2014-12-15 18:17:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801643005/1
6 years ago (2014-12-15 18:21:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 20:23:55 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 20:25:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76e6d7f6c874d06410f56a10d20266c89e25e438
Cr-Commit-Position: refs/heads/master@{#308405}

Powered by Google App Engine
This is Rietveld 408576698