Allow to skip revision check in roll-dep.

Allow to skip revision check in roll-dep.

Without this change, roll-dep requires dependencies to be
checked out and up to date in order to roll a newer revision.

This change allows to use roll-dep with less checking and
makes the script user responsible to verify the correctness
of the deps path and git hash.

This eases writing a deps roller that updates multiple deps
including a variety of os deps, which might not be checked
out on the host of the deps roller.

BUG=438705, 437462
R=jochen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293444

[Michael Achenbach, 2014-12-12 09:53:19]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, szager@chromium.org

[Michael Achenbach, 2014-12-12 09:54:05]

PTAL

[jochen (gone - plz use gerrit), 2014-12-12 10:06:03]

lgtm

[jochen (gone - plz use gerrit), 2014-12-12 10:08:36]

https://codereview.chromium.org/801643004/diff/1/roll_dep.py
File roll_dep.py (right):

https://codereview.chromium.org/801643004/diff/1/roll_dep.py#newcode162
roll_dep.py:162: svn_revision = revision[1:]
nit. add if not git_revision: raise RuntimeError('please git fetch origin')

https://codereview.chromium.org/801643004/diff/1/roll_dep.py#newcode284
roll_dep.py:284: except Exception:
when can this happen? I thought get_svn_revision just returns None if it can't
find it?

[Michael Achenbach, 2014-12-12 10:24:07]

Done

https://codereview.chromium.org/801643004/diff/1/roll_dep.py
File roll_dep.py (right):

https://codereview.chromium.org/801643004/diff/1/roll_dep.py#newcode162
roll_dep.py:162: svn_revision = revision[1:]
On 2014/12/12 10:08:36, jochen (slow) wrote:
> nit. add if not git_revision: raise RuntimeError('please git fetch origin')

Done. I assume you meant two lines below as this condition is for incoming svn
numbers.

https://codereview.chromium.org/801643004/diff/1/roll_dep.py#newcode284
roll_dep.py:284: except Exception:
On 2014/12/12 10:08:36, jochen (slow) wrote:
> when can this happen? I thought get_svn_revision just returns None if it can't
> find it?

It contains also an assertion that raises if git log doesn't work.

[jochen (gone - plz use gerrit), 2014-12-12 10:31:44]

thx

[Michael Achenbach, 2014-12-18 14:43:08]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2014-12-18 14:44:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/801643004/20001

[commit-bot: I haz the power, 2014-12-18 14:46:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-18 14:46:57]

Presubmit check for 801643004-20001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (113 files) (124.93s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:41: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module android
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module blink
W: 13, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module ios
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module presubmit_unittest
E:2003, 6: Unexpected keyword argument 'include_deleted' in function call
(unexpected-keyword-arg)
E:2003, 6: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2003, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2020, 6: Unexpected keyword argument 'include_deleted' in function call
(unexpected-keyword-arg)
E:2020, 6: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2020, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2377, 4: No value for argument 'include_deletes' in function call
(no-value-for-parameter)
E:2396, 4: No value for argument 'file_filter' in function call
(no-value-for-parameter)
E:2636, 6: No value for argument 'include_deletes' in function call
(no-value-for-parameter)


Presubmit checks took 166.6s to calculate.

[Michael Achenbach, 2014-12-18 15:42:50]

Committed patchset #2 (id:20001) manually as 293444.