Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 801623002: Roll GN binaries to r307979 to get the new default logic. (Closed)

Created:
6 years ago by Dirk Pranke
Modified:
6 years ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll GN binaries to r307979 to get the new default logic. This will allow us to specify which binaries are built by default by changing what is declared in a group("default") target in src/BUILD.gn (this was added in r307770). This rolls buildtools to 4995faa. TBR=scottmg@chromium.org, brettw@chromium.org BUG=430215 Committed: https://crrev.com/a4a492b196181beb7c9253ce95a1d6239e1709e9 Cr-Commit-Position: refs/heads/master@{#308050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
6 years ago (2014-12-12 02:41:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801623002/1
6 years ago (2014-12-12 02:43:05 UTC) #3
scottmg
lgtm
6 years ago (2014-12-12 03:38:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 04:36:11 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-12 04:36:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4a492b196181beb7c9253ce95a1d6239e1709e9
Cr-Commit-Position: refs/heads/master@{#308050}

Powered by Google App Engine
This is Rietveld 408576698