Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: chromecast/chromecast.gyp

Issue 801593003: Chromecast: adds date/time to version string for local builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: BUILD_NUMBER --> CAST_BUILD_REVISION Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/chromecast.gyp
diff --git a/chromecast/chromecast.gyp b/chromecast/chromecast.gyp
index a580bfbb62403bad52f7580563a4f720c2a7ca9d..a0ce2ec05d3f30fdeda1c82a7c98e43d311fab9e 100644
--- a/chromecast/chromecast.gyp
+++ b/chromecast/chromecast.gyp
@@ -241,7 +241,7 @@
'<(version_py_path)',
'-e', 'VERSION_FULL="<(version_full)"',
# Revision is taken from buildbot if available; otherwise, a dev string is used.
- '-e', 'CAST_BUILD_REVISION="<!(echo ${BUILD_NUMBER:="local.${USER}"})"',
+ '-e', 'CAST_BUILD_REVISION="<!(echo ${CAST_BUILD_REVISION:="eng.${USER}.<!(date +%Y%m%d.%H%M%S)"})"',
'-e', 'CAST_IS_DEBUG_BUILD=1 if "<(CONFIGURATION_NAME)" == "Debug" else 0',
'common/version.h.in',
'<@(_outputs)',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698