Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 801593003: Chromecast: adds date/time to version string for local builds. (Closed)

Created:
6 years ago by gunsch
Modified:
6 years ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: adds date/time to version string for local builds. R=lcwu@chromium.org,byungchul@chromium.org BUG=None Committed: https://crrev.com/18a4639a41ea2d79b818c30d766e78808fcf2a10 Cr-Commit-Position: refs/heads/master@{#308161}

Patch Set 1 #

Total comments: 2

Patch Set 2 : BUILD_NUMBER --> CAST_BUILD_REVISION #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chromecast/chromecast.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
6 years ago (2014-12-12 02:20:38 UTC) #1
byungchul
https://codereview.chromium.org/801593003/diff/1/chromecast/chromecast.gyp File chromecast/chromecast.gyp (right): https://codereview.chromium.org/801593003/diff/1/chromecast/chromecast.gyp#newcode244 chromecast/chromecast.gyp:244: '-e', 'CAST_BUILD_REVISION="<!(echo ${BUILD_NUMBER:="eng.${USER}.<!(date +%Y%m%d.%H%M%S)"})"', Can we replace BUILD_NUMBER with ...
6 years ago (2014-12-12 05:12:21 UTC) #2
lcwu1
lgtm
6 years ago (2014-12-12 17:28:05 UTC) #3
gunsch
https://codereview.chromium.org/801593003/diff/1/chromecast/chromecast.gyp File chromecast/chromecast.gyp (right): https://codereview.chromium.org/801593003/diff/1/chromecast/chromecast.gyp#newcode244 chromecast/chromecast.gyp:244: '-e', 'CAST_BUILD_REVISION="<!(echo ${BUILD_NUMBER:="eng.${USER}.<!(date +%Y%m%d.%H%M%S)"})"', Done, though this will require ...
6 years ago (2014-12-12 17:29:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801593003/20001
6 years ago (2014-12-12 19:22:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 21:12:45 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-12 21:14:42 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/18a4639a41ea2d79b818c30d766e78808fcf2a10
Cr-Commit-Position: refs/heads/master@{#308161}

Powered by Google App Engine
This is Rietveld 408576698