Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 801553002: Set OS X widget bitmaps immutable, and while we're here use setMatrix(). (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
mtklein, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set OS X widget bitmaps immutable, and while we're here use setMatrix(). I've been playing around with a build of Chrome that asserts all bitmaps recorded into pictures are immutable. Most are, but this one popped out on sites that use native widgets (checkboxes, text fields, etc.). While we're here, we can just call SkCanvas::setMatrix() instead of concating the matrix with its inverse. That works fine with SkPicture now. BUG= Committed: https://crrev.com/e15a3024c393bc935ec004f9a5368312c08c1465 Cr-Commit-Position: refs/heads/master@{#308088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M skia/ext/skia_utils_mac.mm View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein
Try again Mike? (CQ if you're feeling feisty.)
6 years ago (2014-12-12 02:01:31 UTC) #4
reed1
lgtm
6 years ago (2014-12-12 13:54:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801553002/1
6 years ago (2014-12-12 14:29:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 15:24:05 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-12 15:24:51 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e15a3024c393bc935ec004f9a5368312c08c1465
Cr-Commit-Position: refs/heads/master@{#308088}

Powered by Google App Engine
This is Rietveld 408576698