Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: ui/file_manager/file_manager/common/js/util.js

Issue 801533006: Add type annotations to gallery/js/gallery.js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unnecessary annotations. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/common/js/util.js
diff --git a/ui/file_manager/file_manager/common/js/util.js b/ui/file_manager/file_manager/common/js/util.js
index de6afcd970db2820abd68449f7f744fa2429d910..36b637cdfcd05595783c95b43a04c32272340573 100644
--- a/ui/file_manager/file_manager/common/js/util.js
+++ b/ui/file_manager/file_manager/common/js/util.js
@@ -60,7 +60,7 @@ util.FileError = {
PATH_EXISTS_ERR: 'PathExistsError',
QUOTA_EXCEEDED_ERR: 'QuotaExceededError',
TYPE_MISMATCH_ERR: 'TypeMismatchError',
- ENCODING_ERR: 'EncodingError',
+ ENCODING_ERR: 'EncodingError'
fukino 2014/12/12 15:15:25 Sorry for forgetting to share this: https://codere
yawano 2014/12/15 01:45:24 Done.
};
Object.freeze(util.FileError);
@@ -288,9 +288,9 @@ util.createChild = function(parent, opt_className, opt_tag) {
/**
* Updates the app state.
*
- * @param {string} currentDirectoryURL Currently opened directory as an URL.
+ * @param {?string} currentDirectoryURL Currently opened directory as an URL.
fukino 2014/12/12 15:15:25 Could you change the method invocation like this?
yawano 2014/12/15 01:45:24 In the comment of first argument of util.updateApp
fukino 2014/12/15 02:15:28 Thanks! Got it (a little bit confusing interface,
* If null the value is left unchanged.
- * @param {string} selectionURL Currently selected entry as an URL. If null the
+ * @param {?string} selectionURL Currently selected entry as an URL. If null the
* value is left unchanged.
* @param {string|Object=} opt_param Additional parameters, to be stored. If
* null, then left unchanged.
@@ -596,7 +596,7 @@ util.toggleFullScreen = function(appWindow, enabled) {
util.FileOperationType = {
COPY: 'COPY',
MOVE: 'MOVE',
- ZIP: 'ZIP',
+ ZIP: 'ZIP'
};
Object.freeze(util.FileOperationType);
@@ -608,7 +608,7 @@ Object.freeze(util.FileOperationType);
util.FileOperationErrorType = {
UNEXPECTED_SOURCE_FILE: 0,
TARGET_EXISTS: 1,
- FILESYSTEM_ERROR: 2,
+ FILESYSTEM_ERROR: 2
};
Object.freeze(util.FileOperationErrorType);
@@ -619,7 +619,7 @@ Object.freeze(util.FileOperationErrorType);
*/
util.EntryChangedKind = {
CREATED: 0,
- DELETED: 1,
+ DELETED: 1
};
Object.freeze(util.EntryChangedKind);
@@ -727,8 +727,8 @@ util.comparePath = function(entry1, entry2) {
/**
* Checks if {@code entry} is an immediate child of {@code directory}.
*
- * @param {?DirectoryEntry} directory The presumptive parent.
- * @param {?Entry} entry The presumptive child.
+ * @param {Entry} entry The presumptive child.
+ * @param {DirectoryEntry} directory The presumptive parent.
* @return {!Promise.<boolean>} Resolves with true if {@code directory} is
* parent of {@code entry}.
*/

Powered by Google App Engine
This is Rietveld 408576698