Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 80153003: IDL compiler: [CustomLegacyCall] interfaces, cleanup header conditional spacing (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: [CustomLegacyCall] interfaces, cleanup header conditional spacing [CustomLegacyCall] is a simple extended attribute. Also cleaned up the last ad hoc conditional handling in Jinja templates; now it's a consistent {% filter %}. BUG=239771 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162454

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -97 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_interface.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/templates/callback_interface.h View 2 chunks +2 lines, -7 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 3 chunks +5 lines, -8 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + Source/bindings/tests/idls/TestCustomLegacyCallInterface.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8Float64Array.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8SupportTestInterface.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestActiveDOMObjectInterface.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestCallback.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestCheckSecurityInterface.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestConditionalInterface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestConstants.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestCustomAccessors.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestCustomIsReachableInterface.h View 1 1 chunk +0 lines, -1 line 0 comments Download
A + Source/bindings/tests/results/V8TestCustomLegacyCallInterface.h View 1 1 chunk +30 lines, -31 lines 0 comments Download
A + Source/bindings/tests/results/V8TestCustomLegacyCallInterface.cpp View 1 6 chunks +18 lines, -17 lines 0 comments Download
M Source/bindings/tests/results/V8TestDependentLifetimeInterface.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestDoNotCheckConstantsInterface.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestEventConstructor.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestException.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestExtendedEvent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceImplementedAs.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestNamedConstructor.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestOverloadedConstructors.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestSerializedScriptValueInterface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nils Barth (inactive)
7 years, 1 month ago (2013-11-21 04:43:43 UTC) #1
haraken
LGTM This IDL attribute is just for legacy support.
7 years, 1 month ago (2013-11-21 06:25:53 UTC) #2
Nils Barth (inactive)
On 2013/11/21 06:25:53, haraken wrote: > LGTM > > This IDL attribute is just for ...
7 years, 1 month ago (2013-11-21 06:29:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/80153003/1
7 years, 1 month ago (2013-11-21 06:29:36 UTC) #4
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=11642
7 years, 1 month ago (2013-11-21 06:47:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/80153003/110001
7 years, 1 month ago (2013-11-21 06:52:21 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-21 09:42:49 UTC) #7
Message was sent while issue was closed. 
Change committed as 162454

Powered by Google App Engine
This is Rietveld 408576698