Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp - Issue 8015006: Merge 95728 - Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp

Issue 8015006: Merge 95728 - Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/874/

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/webgl/shader-deleted-by-accessor-expected.txt ('k') | Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp

===================================================================

--- Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp (revision 95807)

+++ Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp (working copy)

@@ -212,7 +212,7 @@

WebGLProgram* program = toWebGLProgram(exec->argument(0));

if (exec->hadException())

return jsNull();

- Vector<WebGLShader*> shaders;

+ Vector<RefPtr<WebGLShader> > shaders;

bool succeed = context->getAttachedShaders(program, shaders, ec);

if (ec) {

setDOMException(exec, ec);

@@ -222,7 +222,7 @@

return jsNull();

MarkedArgumentBuffer list;

for (size_t ii = 0; ii < shaders.size(); ++ii)

- list.append(toJS(exec, globalObject(), shaders[ii]));

+ list.append(toJS(exec, globalObject(), shaders[ii].get()));

return constructArray(exec, globalObject(), list);

}