Issue 801443008: PlatformViewportAndroid shouldn't crash on second touch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 801443008: PlatformViewportAndroid shouldn't crash on second touch (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

PlatformViewportAndroid shouldn't crash on second touch We need to mask off the high bits from the |action| before switching on the action because the high bits contain the index number of the touch. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cd8cfdd947725e83334986b1bd2f0758f22d01e2

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -5 lines)			Patch
	M	services/native_viewport/platform_viewport_android.cc	View	1	2 chunks	+18 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

jamesr

I assume we'll want the touch info as well at some point. Is somebody trying ...

5 years, 11 months ago (2015-01-09 00:25:10 UTC) #2

abarth-chromium

On 2015/01/09 at 00:25:10, jamesr wrote: > I assume we'll want the touch info as ...

5 years, 11 months ago (2015-01-09 00:27:20 UTC) #3

abarth-chromium

5 years, 11 months ago (2015-01-09 00:30:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
cd8cfdd947725e83334986b1bd2f0758f22d01e2 (presubmit successful).