Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 801443002: Add image_diff from the chromium repo. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Add image_diff from the chromium repo. This is needed for reference tests so we can diff images. This is just a straight copy of the image diff in the chromium repo. R=eseidel@google.com, esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ac5097e515ce8237ead2c89bc61dc914cb75313b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+688 lines, -350 lines) Patch
M sky/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A sky/tools/imagediff/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download
A sky/tools/imagediff/image_diff.cc View 1 chunk +449 lines, -0 lines 0 comments Download
A sky/tools/imagediff/image_diff_png.h View 1 chunk +35 lines, -0 lines 0 comments Download
A + sky/tools/imagediff/image_diff_png.cc View 19 chunks +183 lines, -350 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ojan
Wasn't sure whether to put this in sky/tools or tools. I imagine we'll want image ...
6 years ago (2014-12-11 17:42:00 UTC) #2
eseidel1
Can we just deps it in? Seems a bit silly to copy we're not gonna ...
6 years ago (2014-12-11 17:43:34 UTC) #4
esprehn
lgtm
6 years ago (2014-12-11 17:43:44 UTC) #5
ojan
On 2014/12/11 at 17:43:34, eseidel wrote: > Can we just deps it in? Seems a ...
6 years ago (2014-12-11 17:50:33 UTC) #6
jamesr
On 2014/12/11 17:50:33, ojan wrote: > On 2014/12/11 at 17:43:34, eseidel wrote: > > Can ...
6 years ago (2014-12-11 18:24:23 UTC) #7
ojan
Committed patchset #1 (id:1) manually as ac5097e515ce8237ead2c89bc61dc914cb75313b (presubmit successful).
6 years ago (2014-12-11 23:21:33 UTC) #8
blundell
6 years ago (2014-12-12 07:12:20 UTC) #9
Message was sent while issue was closed.
On 2014/12/11 23:21:33, ojan wrote:
> Committed patchset #1 (id:1) manually as
> ac5097e515ce8237ead2c89bc61dc914cb75313b (presubmit successful).

FYI, I revert this CL in https://codereview.chromium.org/800773002/ as it broke
the asan build.

Powered by Google App Engine
This is Rietveld 408576698