Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 801413002: fix last warnings on w64 and turn on w.a.e. (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

fix last warnings on w64 and turn on w.a.e. Committed: https://skia.googlesource.com/skia/+/0aa5cea8694d3686b6742a36eab81ab9001de954

Patch Set 1 #

Total comments: 2

Patch Set 2 : simplify logic in common_variables.gypi #

Patch Set 3 : fix/simplify memset bench name printing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -30 lines) Patch
M bench/MemsetBench.cpp View 1 2 4 chunks +8 lines, -9 lines 0 comments Download
M bench/nanobench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkPdfNativeDoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp View 11 chunks +12 lines, -12 lines 0 comments Download
M gyp/common_variables.gypi View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bsalomon
6 years ago (2014-12-15 16:47:27 UTC) #2
mtklein
lgtm https://codereview.chromium.org/801413002/diff/1/gyp/common_variables.gypi File gyp/common_variables.gypi (right): https://codereview.chromium.org/801413002/diff/1/gyp/common_variables.gypi#newcode165 gyp/common_variables.gypi:165: 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "android"] ' ...
6 years ago (2014-12-15 16:51:42 UTC) #3
bsalomon
https://codereview.chromium.org/801413002/diff/1/gyp/common_variables.gypi File gyp/common_variables.gypi (right): https://codereview.chromium.org/801413002/diff/1/gyp/common_variables.gypi#newcode165 gyp/common_variables.gypi:165: 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "android"] ' On ...
6 years ago (2014-12-15 16:54:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801413002/20001
6 years ago (2014-12-15 16:58:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1153)
6 years ago (2014-12-15 17:00:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801413002/40001
6 years ago (2014-12-15 17:04:29 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-15 17:13:41 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0aa5cea8694d3686b6742a36eab81ab9001de954

Powered by Google App Engine
This is Rietveld 408576698