Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 801383002: add dumpHex option to rect and rrect, to match path (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add dumpHex option to rect and rrect, to match path BUG=skia: Committed: https://skia.googlesource.com/skia/+/e05fed0d6339c63c8cceff74af0b8d120c07e54c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -52 lines) Patch
M include/core/SkRRect.h View 1 chunk +3 lines, -7 lines 0 comments Download
M include/core/SkRect.h View 1 chunk +3 lines, -10 lines 0 comments Download
M src/core/SkPath.cpp View 3 chunks +13 lines, -25 lines 0 comments Download
M src/core/SkRRect.cpp View 1 chunk +20 lines, -10 lines 0 comments Download
M src/core/SkRect.cpp View 1 chunk +32 lines, -0 lines 0 comments Download
M src/core/SkStringUtils.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/core/SkStringUtils.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
6 years ago (2014-12-15 15:48:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801383002/1
6 years ago (2014-12-15 15:49:48 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-15 15:49:49 UTC) #5
caryclark
lgtm
6 years ago (2014-12-15 15:52:34 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 15:59:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e05fed0d6339c63c8cceff74af0b8d120c07e54c

Powered by Google App Engine
This is Rietveld 408576698