Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 801373002: Oilpan: force finalization on color chooser closing tests. (Closed)

Created:
6 years ago by sof
Modified:
6 years ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: force finalization on color chooser closing tests. The closing of the color chooser popup window may in the end be triggered by the finalization of the GCed popup UI controller object, so force a GC before testing for the chooser being closed. R=haraken BUG=340522 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M LayoutTests/fast/forms/color/input-color-chooser-shown.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/color/input-color-chooser-shown-readonly.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sof
Please take a look. These two forms layout tests have been failing for a while, ...
6 years ago (2014-12-15 14:55:10 UTC) #2
haraken
LGTM
6 years ago (2014-12-15 14:59:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801373002/1
6 years ago (2014-12-15 15:02:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/41824)
6 years ago (2014-12-15 18:15:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801373002/1
6 years ago (2014-12-15 18:33:32 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-15 18:34:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187162

Powered by Google App Engine
This is Rietveld 408576698