Issue 801353008: Use device-space stroke width for SkDraw::drawRect() quick-reject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 801353008: Use device-space stroke width for SkDraw::drawRect() quick-reject (Closed)

Created:
5 years, 11 months ago by f(malita)

Modified:
5 years, 11 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Use device-space stroke width for SkDraw::drawRect() quick-reject The stroke width needs to be CTM-adjusted when applied to device space rects. BUG=skia:3313 R=reed@google.com Committed: https://skia.googlesource.com/skia/+/1a178ca6dd2ff7f62c684f7d0ee94e54fc31c91b

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -16 lines)			Patch
M	gyp/tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/core/SkDraw.cpp	View	3 chunks	+23 lines, -16 lines	0 comments	Download
A	tests/RectTest.cpp	View	1 chunk	+51 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801353008/1

5 years, 11 months ago (2015-01-15 13:56:57 UTC) #4

commit-bot: I haz the power

5 years, 11 months ago (2015-01-15 14:01:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1a178ca6dd2ff7f62c684f7d0ee94e54fc31c91b