Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 801333002: [turbofan] Remove the no-context hack for JSToNumber. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove the no-context hack for JSToNumber. The ToNumberStub is now able to handle all plain primitives (Numbers, Booleans, Null, Undefined and Strings) without context access. TEST=cctest,mjsunit,unittests Committed: https://crrev.com/d211608a3eb7ef3da4d04fd4f5a8540dedbd1faa Cr-Commit-Position: refs/heads/master@{#25814}

Patch Set 1 #

Patch Set 2 : Improve ARM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -36 lines) Patch
M src/arm/code-stubs-arm.cc View 1 1 chunk +32 lines, -7 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +34 lines, -7 lines 0 comments Download
M src/compiler/js-generic-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +34 lines, -7 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +35 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
PTAL
6 years ago (2014-12-15 10:26:08 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-15 10:45:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801333002/20001
6 years ago (2014-12-15 10:46:08 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-15 11:14:10 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-17 10:13:12 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d211608a3eb7ef3da4d04fd4f5a8540dedbd1faa
Cr-Commit-Position: refs/heads/master@{#25814}

Powered by Google App Engine
This is Rietveld 408576698