Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 801293003: Fix a trace value type in RenderPassDrawQuad. (Closed)

Created:
5 years, 11 months ago by JungJik
Modified:
5 years, 11 months ago
Reviewers:
danakj, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a trace value type in RenderPassDrawQuad. gfx::size's trace value type should be dictionary. Committed: https://crrev.com/97313ec841a23ad5eeb76311e845b8f16fce780f Cr-Commit-Position: refs/heads/master@{#311157}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/quads/render_pass_draw_quad.cc View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
JungJik
PTAL this is for fixing a crash when cc.debug.quad is on.
5 years, 11 months ago (2015-01-12 10:55:49 UTC) #2
danakj
LGTM https://codereview.chromium.org/801293003/diff/1/cc/quads/render_pass_draw_quad.cc File cc/quads/render_pass_draw_quad.cc (right): https://codereview.chromium.org/801293003/diff/1/cc/quads/render_pass_draw_quad.cc#newcode102 cc/quads/render_pass_draw_quad.cc:102: value->BeginDictionary("mask_texture_size"); Oof, this is kinda meh. We can ...
5 years, 11 months ago (2015-01-12 18:03:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801293003/1
5 years, 11 months ago (2015-01-12 23:23:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 00:28:03 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/97313ec841a23ad5eeb76311e845b8f16fce780f Cr-Commit-Position: refs/heads/master@{#311157}
5 years, 11 months ago (2015-01-13 00:28:58 UTC) #8
JungJik
5 years, 11 months ago (2015-01-13 01:04:42 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/801293003/diff/1/cc/quads/render_pass_draw_qu...
File cc/quads/render_pass_draw_quad.cc (right):

https://codereview.chromium.org/801293003/diff/1/cc/quads/render_pass_draw_qu...
cc/quads/render_pass_draw_quad.cc:102:
value->BeginDictionary("mask_texture_size");
On 2015/01/12 18:03:22, danakj wrote:
> Oof, this is kinda meh. We can surely make a better api on MathUtil to do
this,
> maybe pass it the string, the variable, and the value, and have it decide the
> type internally.

thanks for the review.
I understand your intention and will file a new patch.

Powered by Google App Engine
This is Rietveld 408576698