Issue 801283006: Get rid of SelectorCheckingContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 801283006: Get rid of SelectorCheckingContext. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Get rid of SelectorCheckingContext. We can just pass the Element and the scope. I also deleted checkExactAttribute which was not called, and inlined tagMatches which only had a single caller. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/112d8e53929d9f8bef48028eb91e1e3e85fc8de6

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -140 lines)			Patch
M	sky/engine/core/css/ElementRuleCollector.cpp	View		1 chunk	+6 lines, -8 lines	0 comments	Download
M	sky/engine/core/css/SelectorChecker.h	View		2 chunks	+6 lines, -43 lines	0 comments	Download
M	sky/engine/core/css/SelectorChecker.cpp	View	1	7 chunks	+49 lines, -76 lines	0 comments	Download
M	sky/engine/core/dom/SelectorQuery.cpp	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	sky/engine/core/html/HTMLContentElement.cpp	View		1 chunk	+3 lines, -9 lines	0 comments	Download

Total messages: 4 (1 generated)

esprehn

5 years, 11 months ago (2015-01-09 23:17:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
112d8e53929d9f8bef48028eb91e1e3e85fc8de6 (presubmit successful).