Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 801283005: [Android] Fix remote device test run TestPackage() methods. (Closed)

Created:
6 years ago by jbudorick
Modified:
6 years ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix remote device test run TestPackage() methods. BUG=428729 Committed: https://crrev.com/480f002f5478d6037aa8d1cb471207a1189deb23 Cr-Commit-Position: refs/heads/master@{#308382}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M build/android/pylib/remote/device/remote_device_gtest_run.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/remote/device/remote_device_test_run.py View 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_uirobot_run.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/uirobot/uirobot_test_instance.py View 3 chunks +7 lines, -5 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
jbudorick
TestPackage() returning None is causing bot issues.
6 years ago (2014-12-15 16:46:41 UTC) #2
klundberg
lgtm Just a minor nit/question that doesn't have to be fixed in this CL. https://codereview.chromium.org/801283005/diff/1/build/android/pylib/uirobot/uirobot_test_instance.py ...
6 years ago (2014-12-15 16:58:14 UTC) #3
jbudorick
On 2014/12/15 16:58:14, klundberg wrote: > lgtm > > Just a minor nit/question that doesn't ...
6 years ago (2014-12-15 17:00:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801283005/1
6 years ago (2014-12-15 17:01:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 18:59:29 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-15 19:00:36 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/480f002f5478d6037aa8d1cb471207a1189deb23
Cr-Commit-Position: refs/heads/master@{#308382}

Powered by Google App Engine
This is Rietveld 408576698