Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 801263002: [turbofan] Correctify TruncateFloat64ToInt32 reduction in MachineOperatorReducer. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Correctify TruncateFloat64ToInt32 reduction in MachineOperatorReducer. TEST=unittests R=svenpanne@chromium.org Committed: https://crrev.com/6e7ceee4d02a81f167d47d8c6dc57a226b8d98d4 Cr-Commit-Position: refs/heads/master@{#25812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -22 lines) Patch
M src/compiler/machine-operator-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +43 lines, -22 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
PTAL
6 years ago (2014-12-15 06:50:39 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-15 07:42:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801263002/1
6 years ago (2014-12-15 07:43:36 UTC) #5
Benedikt Meurer
Committed patchset #1 (id:1) manually as 6e7ceee4d02a81f167d47d8c6dc57a226b8d98d4 (presubmit successful).
6 years ago (2014-12-15 07:46:28 UTC) #7
Benedikt Meurer
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/794473003/ by bmeurer@chromium.org. ...
6 years ago (2014-12-17 09:50:15 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-17 10:13:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e7ceee4d02a81f167d47d8c6dc57a226b8d98d4
Cr-Commit-Position: refs/heads/master@{#25812}

Powered by Google App Engine
This is Rietveld 408576698