extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h - Issue 801173002: Fix message routing for BrowserPlugin in iframe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

Issue 801173002: Fix message routing for BrowserPlugin in iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More cleanup Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/api/guest_view_internal.json ('K') | « extensions/renderer/guest_view/guest_view_container.cc ('k') | extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

diff --git a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

index 5fcf51637814afd5ada14b88d104c5dbbcd331e7..9ba3fc8814dfac8266a41e2a31f9038e5ef9d632 100644

--- a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

+++ b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

@@ -39,12 +39,9 @@ class MimeHandlerViewContainer : public GuestViewContainer,

// BrowserPluginDelegate implementation.

void DidFinishLoading() override;

void DidReceiveData(const char* data, int data_length) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

void Ready() override;

- // GuestViewContainer overrides.

- bool HandlesMessage(const IPC::Message& message) override;

- bool OnMessage(const IPC::Message& message) override;

// WebURLLoaderClient overrides.

void didReceiveData(blink::WebURLLoader* loader,

const char* data,