Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2216)

Unified Diff: extensions/renderer/guest_view/extensions_guest_view_container.cc

Issue 801173002: Fix message routing for BrowserPlugin in iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests that don't have a RenderThreadImpl Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/extensions_guest_view_container.cc
diff --git a/extensions/renderer/guest_view/extensions_guest_view_container.cc b/extensions/renderer/guest_view/extensions_guest_view_container.cc
index 94735200dc026e1c3da3deebf98034a3031e03f9..c9ac9416eaed95f9f1a4ba0292acbf70fc5abc01 100644
--- a/extensions/renderer/guest_view/extensions_guest_view_container.cc
+++ b/extensions/renderer/guest_view/extensions_guest_view_container.cc
@@ -186,6 +186,12 @@ void ExtensionsGuestViewContainer::RegisterDestructionCallback(
destruction_isolate_ = isolate;
}
+bool ExtensionsGuestViewContainer::OnMessageReceived(
+ const IPC::Message& message) {
+ OnHandleCallback(message);
+ return true;
+}
+
void ExtensionsGuestViewContainer::SetElementInstanceID(
int element_instance_id) {
GuestViewContainer::SetElementInstanceID(element_instance_id);
@@ -202,16 +208,6 @@ void ExtensionsGuestViewContainer::Ready() {
PerformPendingRequest();
}
-bool ExtensionsGuestViewContainer::HandlesMessage(const IPC::Message& message) {
- return (message.type() == ExtensionMsg_GuestAttached::ID) ||
- (message.type() == ExtensionMsg_GuestDetached::ID);
-}
-
-bool ExtensionsGuestViewContainer::OnMessage(const IPC::Message& message) {
- OnHandleCallback(message);
- return true;
-}
-
void ExtensionsGuestViewContainer::OnHandleCallback(
const IPC::Message& message) {
// Handle the callback for the current request with a pending response.

Powered by Google App Engine
This is Rietveld 408576698