extensions/browser/guest_view/guest_view_base.cc - Issue 801173002: Fix message routing for BrowserPlugin in iframe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 801173002: Fix message routing for BrowserPlugin in iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests that don't have a RenderThreadImpl Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/guest_view_base.cc

diff --git a/extensions/browser/guest_view/guest_view_base.cc b/extensions/browser/guest_view/guest_view_base.cc

index 44626e86e4527aa2d4bd529e59a6c3581300591d..c7139857bacfefab33deb4b7d00b482912a923a3 100644

--- a/extensions/browser/guest_view/guest_view_base.cc

+++ b/extensions/browser/guest_view/guest_view_base.cc

@@ -322,7 +322,6 @@ void GuestViewBase::DidAttach(int guest_proxy_routing_id) {

// Inform the associated GuestViewContainer that the contentWindow is ready.

embedder_web_contents()->Send(new ExtensionMsg_GuestAttached(

- embedder_web_contents()->GetMainFrame()->GetRoutingID(),

element_instance_id_,

guest_proxy_routing_id));

@@ -334,7 +333,6 @@ void GuestViewBase::DidDetach() {

this, element_instance_id_);

StopTrackingEmbedderZoomLevel();

owner_web_contents()->Send(new ExtensionMsg_GuestDetached(

- owner_web_contents()->GetMainFrame()->GetRoutingID(),

element_instance_id_));

element_instance_id_ = guestview::kInstanceIDNone;

}