content/browser/browser_plugin/browser_plugin_guest.h - Issue 801173002: Fix message routing for BrowserPlugin in iframe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 801173002: Fix message routing for BrowserPlugin in iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests that don't have a RenderThreadImpl Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_plugin/browser_plugin_guest.h

diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h

index 6e6c2761fe64431e9e18964139d09a97aa80bdb5..20d418fffa964cfc40ba613668c0d8b1d805bd00 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.h

+++ b/content/browser/browser_plugin/browser_plugin_guest.h

@@ -171,8 +171,8 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {

gfx::Point GetScreenCoordinates(const gfx::Point& relative_position) const;

- // Helper to send messages to embedder. This methods fills the message with

- // the correct routing id.

+ // Helper to send messages to embedder. If this guest is not yet attached,

+ // then IPCs will be queued until attachment.

void SendMessageToEmbedder(IPC::Message* msg);

// Returns whether the guest is attached to an embedder.