Fix message routing for BrowserPlugin in iframe

chrome/browser/apps/web_view_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/path_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/apps/app_browsertest_util.h"
 #include "chrome/browser/chrome_content_browser_client.h"
 #include "chrome/browser/prerender/prerender_link_manager.h"
@@ skipping 2406 matching lines @@
   // Get an existing registered rule for the guest.
   extensions::RulesRegistry* registry =
       registry_service->GetRulesRegistry(
           rules_registry_id,
           extensions::declarative_webrequest_constants::kOnRequest).get();
 
   EXPECT_TRUE(registry);
   EXPECT_FALSE(registry->rules_cache_delegate_for_testing());
 }
 
+// This test verify that the set of rules registries of a webview will be

[Charlie Reis, 2014/12/18 00:27:40]

nit: verifies

[Fady Samuel, 2014/12/18 00:35:50]

Done.

+// removed from RulesRegistryService after the webview is gone.
+// http://crbug.com/438327

[Charlie Reis, 2014/12/18 00:27:40]

This is a different bug number.  Is it a related bug, or just a typo?

Also the comment should probably mention that this is for the iframe case, since
it's the main emphasis.

[Fady Samuel, 2014/12/18 00:35:50]

Doh. Blind copy and paste. Fixed.

+IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestWebViewInsideFrame) {
+  LoadAppWithGuest("web_view/inside_iframe");

[Charlie Reis, 2014/12/18 00:27:39]

Does this file need to be added?

[Fady Samuel, 2014/12/18 00:35:50]

Yes.

+}
+
 // <webview> screenshot capture fails with ubercomp.
 // See http://crbug.com/327035.
 IN_PROC_BROWSER_TEST_F(WebViewCaptureTest,
                        DISABLED_Shim_ScreenshotCapture) {
   TestHelper("testScreenshotCapture", "web_view/shim", NO_TEST_SERVER);
 }
 
 #if defined(OS_WIN)
 // Test is disabled on Windows because it times out often.
 // http://crbug.com/403325
 #define MAYBE_WebViewInBackgroundPage \
     DISABLED_WebViewInBackgroundPage
 #else
 #define MAYBE_WebViewInBackgroundPage WebViewInBackgroundPage
 #endif
 IN_PROC_BROWSER_TEST_F(WebViewTest, MAYBE_WebViewInBackgroundPage) {
   ASSERT_TRUE(RunExtensionTest("platform_apps/web_view/background"))
       << message_;
 }