Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 801123002: Improve sizeviewer for Windows (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
jam, mkosiba (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve sizeviewer for Windows Now breaks down to the line level, and shows an annotated display of the source file with the size cost of each line, as well as all symbols that contribute to that size (can be many in the case of templates). Example output here: https://dl.dropboxusercontent.com/u/116514/chrome.dll.html https://dl.dropboxusercontent.com/u/116514/chrome_child.dll.html Not really intended for loading remotely as they're very large, but might eventually finish loading. R=jam@chromium.org, mkosiba@chromium.org BUG=441867 Committed: https://chromium.googlesource.com/chromium/src/+/a055ad288eb18cc186ea7fb5528ffc99a8ac434c

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : more stuff #

Patch Set 5 : update readme #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8978 lines, -166 lines) Patch
M android_webview/tools/third_party_files_whitelist.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/win/sizeviewer/README.chromium View 1 2 3 4 5 1 chunk +7 lines, -2 lines 0 comments Download
A tools/win/sizeviewer/clike.js View 1 chunk +489 lines, -0 lines 0 comments Download
A tools/win/sizeviewer/codemirror.js View 1 chunk +7922 lines, -0 lines 0 comments Download
A tools/win/sizeviewer/favicon.png View 1 2 3 Binary file 0 comments Download
A tools/win/sizeviewer/main.js View 1 2 3 4 5 6 1 chunk +116 lines, -0 lines 0 comments Download
M tools/win/sizeviewer/sizeviewer.py View 1 2 3 4 5 6 7 4 chunks +114 lines, -19 lines 0 comments Download
M tools/win/sizeviewer/template.html View 1 2 3 4 5 6 7 8 1 chunk +326 lines, -145 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
scottmg
6 years ago (2014-12-14 21:52:31 UTC) #2
mkosiba (inactive)
aw/ LGTM
6 years ago (2014-12-15 10:12:10 UTC) #4
jam
rubberstamp lgtm I would really prefer if one tool worked for all platforms. the existing ...
6 years ago (2014-12-15 19:20:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801123002/160001
6 years ago (2014-12-15 19:25:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/104521) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/42111) android_arm64_dbg_recipe ...
6 years ago (2014-12-15 19:30:47 UTC) #9
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/a055ad288eb18cc186ea7fb5528ffc99a8ac434c Cr-Commit-Position: refs/heads/master@{#308394}
6 years ago (2014-12-15 19:42:50 UTC) #10
scottmg
6 years ago (2014-12-15 19:42:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #9 (id:160001) manually as
a055ad288eb18cc186ea7fb5528ffc99a8ac434c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698