Issue 801093002: Delete Channel::SerializeEndpoint().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 801093002: Delete Channel::SerializeEndpoint(). (Closed)

Created:
6 years ago by viettrungluu

Modified:
6 years ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Delete Channel::SerializeEndpoint(). (Make RemoteMessagePipeTest.Multiplex not use it -- instead, it serializes message pipes like everyone else.) R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5096aa91172b9496f5ab1faf1e38a88cdf1cf065

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -21 lines)			Patch
M	mojo/edk/system/channel.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	mojo/edk/system/channel.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	mojo/edk/system/remote_message_pipe_unittest.cc	View	1 chunk	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years ago (2014-12-13 01:19:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5096aa91172b9496f5ab1faf1e38a88cdf1cf065 (presubmit successful).

Expand Messages | Collapse Messages