Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: Source/web/tests/WebFrameTest.cpp

Issue 801063002: Remove setSurfaceReady from WebLayerTreeView. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | public/platform/WebLayerTreeView.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 4260 matching lines...) Expand 10 before | Expand all | Expand 10 after
4271 EXPECT_EQ(startRect, initialStartRect); 4271 EXPECT_EQ(startRect, initialStartRect);
4272 EXPECT_EQ(endRect, initialEndRect); 4272 EXPECT_EQ(endRect, initialEndRect);
4273 } 4273 }
4274 #endif 4274 #endif
4275 4275
4276 class CompositedSelectionBoundsTestLayerTreeView : public WebLayerTreeView { 4276 class CompositedSelectionBoundsTestLayerTreeView : public WebLayerTreeView {
4277 public: 4277 public:
4278 CompositedSelectionBoundsTestLayerTreeView() : m_selectionCleared(false) { } 4278 CompositedSelectionBoundsTestLayerTreeView() : m_selectionCleared(false) { }
4279 virtual ~CompositedSelectionBoundsTestLayerTreeView() { } 4279 virtual ~CompositedSelectionBoundsTestLayerTreeView() { }
4280 4280
4281 virtual void setSurfaceReady() override { }
4282 virtual void setRootLayer(const WebLayer&) override { } 4281 virtual void setRootLayer(const WebLayer&) override { }
4283 virtual void clearRootLayer() override { } 4282 virtual void clearRootLayer() override { }
4284 virtual void setViewportSize(const WebSize& deviceViewportSize) override { } 4283 virtual void setViewportSize(const WebSize& deviceViewportSize) override { }
4285 virtual WebSize deviceViewportSize() const override { return WebSize(); } 4284 virtual WebSize deviceViewportSize() const override { return WebSize(); }
4286 virtual void setDeviceScaleFactor(float) override { } 4285 virtual void setDeviceScaleFactor(float) override { }
4287 virtual float deviceScaleFactor() const override { return 1.f; } 4286 virtual float deviceScaleFactor() const override { return 1.f; }
4288 virtual void setBackgroundColor(WebColor) override { } 4287 virtual void setBackgroundColor(WebColor) override { }
4289 virtual void setHasTransparentBackground(bool) override { } 4288 virtual void setHasTransparentBackground(bool) override { }
4290 virtual void setVisible(bool) override { } 4289 virtual void setVisible(bool) override { }
4291 virtual void setPageScaleFactorAndLimits(float pageScaleFactor, float minimu m, float maximum) override { } 4290 virtual void setPageScaleFactorAndLimits(float pageScaleFactor, float minimu m, float maximum) override { }
(...skipping 2632 matching lines...) Expand 10 before | Expand all | Expand 10 after
6924 EXPECT_EQ(1u, frameClient.navigationalDataReceivedCount()); 6923 EXPECT_EQ(1u, frameClient.navigationalDataReceivedCount());
6925 6924
6926 // Neither should a page reload. 6925 // Neither should a page reload.
6927 localFrame->reload(); 6926 localFrame->reload();
6928 EXPECT_EQ(4u, frameClient.provisionalLoadCount()); 6927 EXPECT_EQ(4u, frameClient.provisionalLoadCount());
6929 EXPECT_FALSE(frameClient.wasLastProvisionalLoadATransition()); 6928 EXPECT_FALSE(frameClient.wasLastProvisionalLoadATransition());
6930 EXPECT_EQ(1u, frameClient.navigationalDataReceivedCount()); 6929 EXPECT_EQ(1u, frameClient.navigationalDataReceivedCount());
6931 } 6930 }
6932 6931
6933 } // namespace 6932 } // namespace
OLDNEW
« no previous file with comments | « no previous file | public/platform/WebLayerTreeView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698