Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 801053009: ASSERTION FAILED: newStartAngle >= 0 && newStartAngle < twoPiFloat. (Closed)

Created:
5 years, 11 months ago by zino
Modified:
5 years, 11 months ago
Reviewers:
dshwang, Justin Novosad
CC:
blink-reviews, aandrey+blink_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ASSERTION FAILED: newStartAngle >= 0 && newStartAngle < twoPiFloat. We can calculate |newStartAngle| as follows if |startAngle| is negative value. newStartAngle = twoPiFloat + fmodf(startAngle, -twoPiFloat); The fmodf() is always 0 if |startAngle| is negative multiples of |twoPiFloat|. So, |newStartAngle| will be |twoPiFloat| and it causes assertion failure. BUG=449053 TEST=https://cluster-fuzz.appspot.com/testcase?key=4815021346390016 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/core/html/canvas/CanvasPathMethods.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zino
Please take a look. Thank you.
5 years, 11 months ago (2015-01-15 13:40:40 UTC) #2
dshwang
non-owner lgtm, thx
5 years, 11 months ago (2015-01-15 15:59:38 UTC) #3
Justin Novosad
On 2015/01/15 15:59:38, dshwang wrote: > non-owner lgtm, thx lgtm
5 years, 11 months ago (2015-01-15 16:03:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801053009/1
5 years, 11 months ago (2015-01-16 00:20:46 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 01:11:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188510

Powered by Google App Engine
This is Rietveld 408576698