Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 801053003: Never display unauthorized plugin info bar (Closed)

Created:
6 years ago by Will Harris
Modified:
6 years ago
Reviewers:
Ilya Sherman, sky
CC:
chromium-reviews, stuartmorgan+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Never display unauthorized plugin info bar. The IPC still needs to be sent because it's used by the webview permission helper to permit PPAPI plugins to run inside a webview. Remove all the code that backed this, including UMA actions, and a test. The NPAPI purge, begun, it has. BUG=439972 Committed: https://crrev.com/4ecfe306cc14acd30a2206bc04d203281ed1d3f3 Cr-Commit-Position: refs/heads/master@{#308433}

Patch Set 1 #

Patch Set 2 : UnauthorizedPluginInfoBarDelegate can go now #

Patch Set 3 : can remove more stuff #

Total comments: 2

Patch Set 4 : remove a header file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -256 lines) Patch
M chrome/browser/chrome_browser_field_trials.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/plugins/npapi_infobar_browsertest.cc View 1 2 1 chunk +0 lines, -115 lines 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 1 2 3 2 chunks +0 lines, -87 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Will Harris
6 years ago (2014-12-13 06:22:51 UTC) #2
sky
LGTM https://codereview.chromium.org/801053003/diff/40001/chrome/browser/plugins/plugin_infobar_delegates.cc File chrome/browser/plugins/plugin_infobar_delegates.cc (left): https://codereview.chromium.org/801053003/diff/40001/chrome/browser/plugins/plugin_infobar_delegates.cc#oldcode85 chrome/browser/plugins/plugin_infobar_delegates.cc:85: // UnauthorizedPluginInfoBarDelegate ------------------------------------------ If there are any dead ...
6 years ago (2014-12-15 16:45:40 UTC) #3
Will Harris
thanks for the review https://codereview.chromium.org/801053003/diff/40001/chrome/browser/plugins/plugin_infobar_delegates.cc File chrome/browser/plugins/plugin_infobar_delegates.cc (left): https://codereview.chromium.org/801053003/diff/40001/chrome/browser/plugins/plugin_infobar_delegates.cc#oldcode85 chrome/browser/plugins/plugin_infobar_delegates.cc:85: // UnauthorizedPluginInfoBarDelegate ------------------------------------------ On 2014/12/15 ...
6 years ago (2014-12-15 19:23:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801053003/60001
6 years ago (2014-12-15 19:25:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/30548)
6 years ago (2014-12-15 19:36:22 UTC) #8
Ilya Sherman
actions.xml lgtm, thanks
6 years ago (2014-12-15 21:16:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801053003/60001
6 years ago (2014-12-15 21:18:36 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-15 22:01:09 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-15 22:02:45 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4ecfe306cc14acd30a2206bc04d203281ed1d3f3
Cr-Commit-Position: refs/heads/master@{#308433}

Powered by Google App Engine
This is Rietveld 408576698