Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 801033003: remove WTF::Complex (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
crogers, Nico, Raymond Toy
CC:
blink-reviews, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

remove WTF::Complex WTF::Complex looks pretty useless- all it does is provide a typedef for std::complex and an inline implementation of std::polar. It looks like it was planned to be extended at some point, but that never happened: https://bugs.webkit.org/show_bug.cgi?id=34538 Let's remove it. BUG=442004 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187086

Patch Set 1 : remove complexFromMagnitudePhase #

Patch Set 2 : remove WTF::Complex typedef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -69 lines) Patch
M Source/modules/webaudio/RealtimeAnalyser.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/audio/Biquad.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/audio/Biquad.cpp View 1 3 chunks +8 lines, -7 lines 0 comments Download
M Source/platform/audio/FFTFrame.cpp View 5 chunks +8 lines, -7 lines 0 comments Download
D Source/wtf/Complex.h View 1 1 chunk +0 lines, -49 lines 0 comments Download
M Source/wtf/wtf.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Mostyn Bramley-Moore
@Nico: please take a look.
6 years ago (2014-12-13 01:33:33 UTC) #2
Nico
lgtm, makes sense
6 years ago (2014-12-13 01:39:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801033003/20001
6 years ago (2014-12-13 01:41:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/22176)
6 years ago (2014-12-13 04:16:11 UTC) #8
Mostyn Bramley-Moore
On 2014/12/13 04:16:11, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years ago (2014-12-13 06:06:38 UTC) #10
Raymond Toy
lgtm
6 years ago (2014-12-13 06:14:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801033003/20001
6 years ago (2014-12-13 06:14:49 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-13 06:17:37 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187086

Powered by Google App Engine
This is Rietveld 408576698