Use the libc clone wrapper in sys_clone.

sandbox/linux/services/syscall_wrappers.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/linux/services/syscall_wrappers.h"
 
+#include <pthread.h>
+#include <sched.h>
+#include <setjmp.h>
 #include <sys/resource.h>
 #include <sys/syscall.h>
 #include <sys/time.h>
 #include <sys/types.h>
 #include <unistd.h>
 
+#include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "build/build_config.h"
 #include "sandbox/linux/services/linux_syscalls.h"
 
 namespace sandbox {
 
 pid_t sys_getpid(void) {
   return syscall(__NR_getpid);
 }
 
 pid_t sys_gettid(void) {
   return syscall(__NR_gettid);
 }
 
-long sys_clone(unsigned long flags) {
-  return sys_clone(flags, nullptr, nullptr, nullptr, nullptr);
+namespace {
+
+int CloneHelper(void* arg) {
+  jmp_buf* env_ptr = reinterpret_cast<jmp_buf*>(arg);
+  // This function runs on the stack specified on the clone call. Use longjmp to
+  // switch back to the original stack so the child can return from sys_clone.
+  longjmp(*env_ptr, 1);
+
+  // Should not be reached.
+  RAW_CHECK(false);
+  return 1;
 }
 
+}  // namespace
+
 long sys_clone(unsigned long flags,
-               void* child_stack,
+               decltype(nullptr) child_stack,
                pid_t* ptid,
                pid_t* ctid,
                decltype(nullptr) tls) {
   const bool clone_tls_used = flags & CLONE_SETTLS;
   const bool invalid_ctid =
       (flags & (CLONE_CHILD_SETTID | CLONE_CHILD_CLEARTID)) && !ctid;
   const bool invalid_ptid = (flags & CLONE_PARENT_SETTID) && !ptid;
-  const bool invalid_stack = (flags & CLONE_VM) && !child_stack;
 
-  if (clone_tls_used || invalid_ctid || invalid_ptid || invalid_stack) {
+  // Since child_stack must be nullptr, we do not support CLONE_VM.
+  const bool clone_vm_used = flags & CLONE_VM;
+
+  if (clone_tls_used || invalid_ctid || invalid_ptid || clone_vm_used) {
     RAW_LOG(FATAL, "Invalid usage of sys_clone");
   }
 
-// See kernel/fork.c in Linux. There is different ordering of sys_clone
-// parameters depending on CONFIG_CLONE_BACKWARDS* configuration options.
-#if defined(ARCH_CPU_X86_64)
-  return syscall(__NR_clone, flags, child_stack, ptid, ctid, tls);
-#elif defined(ARCH_CPU_X86) || defined(ARCH_CPU_ARM_FAMILY) || \
-    defined(ARCH_CPU_MIPS_FAMILY) || defined(ARCH_CPU_MIPS64_FAMILY)
-  // CONFIG_CLONE_BACKWARDS defined.
-  return syscall(__NR_clone, flags, child_stack, ptid, tls, ctid);
+  jmp_buf env;
+  if (setjmp(env) == 0) {
+    // We use the libc clone wrapper instead of making the syscall
+    // directly because making the syscall may fail to update the libc's
+    // internal pid cache. The libc interface unfortunately requires
+    // specifying a new stack, so we use setjmp/longjmp to emulate
+    // fork-like behavior.
+    char stack_buf[PTHREAD_STACK_MIN];
+#if defined(__x86_64__) || defined(__i386__) || defined(__arm__) || \

[jln (very slow on Chromium), 2014/12/16 01:37:51]

Nit: might be better to rely on what build_config.h defines for us instead.

+    defined(__mips__) || defined(__aarch64__)
+    // The stack grows downward.
+    void* stack = stack_buf + sizeof(stack_buf);
+#else
+#error "Unsupported architecture"
 #endif
+    return clone(&CloneHelper, stack, flags, &env, ptid, tls, ctid);
+  }
+
+  return 0;
+}
+
+long sys_clone(unsigned long flags) {
+  return sys_clone(flags, nullptr, nullptr, nullptr, nullptr);
 }
 
 void sys_exit_group(int status) {
   syscall(__NR_exit_group, status);
 }
 
 int sys_seccomp(unsigned int operation,
                 unsigned int flags,
                 const struct sock_fprog* args) {
   return syscall(__NR_seccomp, operation, flags, args);
 }
 
 int sys_prlimit64(pid_t pid,
                   int resource,
                   const struct rlimit64* new_limit,
                   struct rlimit64* old_limit) {
   return syscall(__NR_prlimit64, pid, resource, new_limit, old_limit);
 }
 
 }  // namespace sandbox