Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 800993003: Android: Allow sandboxed utility process (Closed)

Created:
6 years ago by no sievers
Modified:
6 years ago
Reviewers:
Feng Qian
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Allow sandboxed utility process DCHECK() that it was not launched with DisableSandbox(). The utility process is used for sandboxed image decoding (and probably only that) on Android. BUG=396568 NOTRY=True Committed: https://crrev.com/9ffb198d00f53489e6b94e11f45ef4589c5a9199 Cr-Commit-Position: refs/heads/master@{#308162}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M content/browser/child_process_launcher.cc View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 1 2 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
no sievers
ptal
6 years ago (2014-12-12 20:16:28 UTC) #2
no sievers
ptal
6 years ago (2014-12-12 20:16:29 UTC) #3
Feng Qian
lgtm https://codereview.chromium.org/800993003/diff/40001/content/browser/child_process_launcher.cc File content/browser/child_process_launcher.cc (right): https://codereview.chromium.org/800993003/diff/40001/content/browser/child_process_launcher.cc#newcode192 content/browser/child_process_launcher.cc:192: // Non-sandboxed utility or rendererprocess are currently not ...
6 years ago (2014-12-12 20:59:46 UTC) #4
no sievers
https://codereview.chromium.org/800993003/diff/40001/content/browser/child_process_launcher.cc File content/browser/child_process_launcher.cc (right): https://codereview.chromium.org/800993003/diff/40001/content/browser/child_process_launcher.cc#newcode192 content/browser/child_process_launcher.cc:192: // Non-sandboxed utility or rendererprocess are currently not supported. ...
6 years ago (2014-12-12 21:14:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800993003/60001
6 years ago (2014-12-12 21:14:50 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-12 21:16:10 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-12 21:16:58 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9ffb198d00f53489e6b94e11f45ef4589c5a9199
Cr-Commit-Position: refs/heads/master@{#308162}

Powered by Google App Engine
This is Rietveld 408576698