Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 800983006: Update {virtual,override,final} to follow C++11 style in ash. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
James Cook
CC:
dcheng, chromium-reviews, derat+watch_chromium.org, kalyank, oshima+watch_chromium.org, sadrul, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in ash. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=jamescook@chromium.org Committed: https://crrev.com/222b9c73256c2c8b2e119ca55cb8a8426b93d5db Cr-Commit-Position: refs/heads/master@{#311791}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Workaround #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -432 lines) Patch
M ash/ash_touch_exploration_manager_chromeos.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/autoclick/autoclick_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/display/display_change_observer_chromeos.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/display/display_configurator_animation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/display/display_configurator_animation.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M ash/display/display_error_observer_chromeos.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_error_observer_chromeos_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/display/display_manager.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M ash/display/projecting_observer_chromeos.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/projecting_observer_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/resolution_notification_controller.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ash/display/resolution_notification_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/display/resolution_notification_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/first_run/first_run_helper_unittest.cc View 5 chunks +8 lines, -12 lines 0 comments Download
M ash/focus_cycler_unittest.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M ash/sticky_keys/sticky_keys_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ash/system/chromeos/audio/audio_detailed_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/audio/tray_audio_chromeos.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/audio/tray_audio_delegate_chromeos.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/system/chromeos/bluetooth/bluetooth_notification_controller.h View 1 chunk +17 lines, -20 lines 0 comments Download
M ash/system/chromeos/bluetooth/bluetooth_notification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/brightness/brightness_controller_chromeos.h View 1 chunk +5 lines, -6 lines 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.h View 2 chunks +11 lines, -11 lines 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M ash/system/chromeos/brightness/tray_brightness_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/enterprise/tray_enterprise.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/system/chromeos/keyboard_brightness_controller.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ash/system/chromeos/label_tray_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/multi_user/user_switch_util.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M ash/system/chromeos/multi_user/user_switch_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/network/network_detailed_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_sms.h View 1 chunk +8 lines, -9 lines 0 comments Download
M ash/system/chromeos/network/tray_sms.cc View 6 chunks +8 lines, -15 lines 0 comments Download
M ash/system/chromeos/power/power_event_observer.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/system/chromeos/power/power_event_observer_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/power/power_status.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/system/chromeos/power/power_status_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/system/chromeos/power/power_status_view.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ash/system/chromeos/power/power_status_view_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M ash/system/chromeos/power/tray_power.h View 2 chunks +10 lines, -12 lines 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/system/chromeos/power/tray_power_unittest.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M ash/system/chromeos/power/video_activity_notifier.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/screen_security/screen_capture_tray_item.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/system/chromeos/screen_security/screen_share_tray_item.h View 1 chunk +8 lines, -9 lines 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item.h View 5 chunks +12 lines, -14 lines 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/system/chromeos/session/last_window_closed_logout_reminder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/session/logout_button_tray.h View 1 chunk +8 lines, -10 lines 0 comments Download
M ash/system/chromeos/session/logout_button_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/logout_confirmation_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/session/logout_confirmation_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/logout_confirmation_dialog.h View 1 chunk +7 lines, -8 lines 0 comments Download
M ash/system/chromeos/session/tray_session_length_limit.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/system/chromeos/session/tray_session_length_limit_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ash/system/chromeos/settings/tray_settings.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/system/chromeos/settings/tray_settings.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/system_clock_observer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/tray_caps_lock.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/system/chromeos/tray_caps_lock.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/tray_display.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/tray_display.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_display_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/tray_tracing.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h View 1 chunk +8 lines, -10 lines 0 comments Download
M ash/system/ime/tray_ime_chromeos_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/tray/media_security/multi_profile_media_tray_item.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/tray/media_security/multi_profile_media_tray_item.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/user/user_card_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/touch/touch_observer_hud.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_transformer_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/touch/touchscreen_util_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ash/virtual_keyboard_controller.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/virtual_keyboard_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/boot_splash_screen_chromeos.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/power_button_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 4 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
dcheng
5 years, 11 months ago (2015-01-15 19:57:50 UTC) #1
James Cook
LGTM with one question https://codereview.chromium.org/800983006/diff/1/ash/system/chromeos/screen_security/screen_tray_item.h File ash/system/chromeos/screen_security/screen_tray_item.h (right): https://codereview.chromium.org/800983006/diff/1/ash/system/chromeos/screen_security/screen_tray_item.h#newcode121 ash/system/chromeos/screen_security/screen_tray_item.h:121: views::View* CreateTrayView(user::LoginStatus status) override = ...
5 years, 11 months ago (2015-01-15 20:43:18 UTC) #2
dcheng
https://codereview.chromium.org/800983006/diff/1/ash/system/chromeos/screen_security/screen_tray_item.h File ash/system/chromeos/screen_security/screen_tray_item.h (right): https://codereview.chromium.org/800983006/diff/1/ash/system/chromeos/screen_security/screen_tray_item.h#newcode121 ash/system/chromeos/screen_security/screen_tray_item.h:121: views::View* CreateTrayView(user::LoginStatus status) override = 0; On 2015/01/15 20:43:18, ...
5 years, 11 months ago (2015-01-15 21:01:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800983006/1
5 years, 11 months ago (2015-01-15 21:02:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/50279) Try jobs failed on following ...
5 years, 11 months ago (2015-01-15 21:15:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800983006/20001
5 years, 11 months ago (2015-01-15 21:42:32 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-16 00:48:32 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:49:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/222b9c73256c2c8b2e119ca55cb8a8426b93d5db
Cr-Commit-Position: refs/heads/master@{#311791}

Powered by Google App Engine
This is Rietveld 408576698