chrome/browser/safe_browsing/incident_reporting/omnibox_watcher.cc - Issue 800983005: Revert of Omnibox Watcher: Don't Flag Incidents that are Paste+Enter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/omnibox_watcher.cc

Issue 800983005: Revert of Omnibox Watcher: Don't Flag Incidents that are Paste+Enter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/incident_reporting/omnibox_watcher.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/omnibox_watcher.cc b/chrome/browser/safe_browsing/incident_reporting/omnibox_watcher.cc

index 1509f35d19aaa94e8f8061f7d94449c45457c1d9..4e0a08c04dcf000608d4f0673e7f3880f051f405 100644

--- a/chrome/browser/safe_browsing/incident_reporting/omnibox_watcher.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/omnibox_watcher.cc

@@ -37,8 +37,8 @@

// No normal person can type URLs that fast! Navigating to a URL as a

// result of such typing is suspicious.

// TODO(mpearson): Add support for suspicious queries.

- if (!log->is_paste_and_go && !log->last_action_was_paste &&

- log->is_popup_open && (log->text.length() > 200) &&

+ if (!log->is_paste_and_go && log->is_popup_open &&

+ (log->text.length() > 200) &&

(log->elapsed_time_since_user_first_modified_omnibox <

base::TimeDelta::FromSeconds(1)) &&

!AutocompleteMatch::IsSearchType(selected_suggestion.type)) {

« no previous file with comments | « chrome/browser/omnibox/omnibox_log.cc ('k') | chrome/browser/ui/omnibox/omnibox_edit_model.cc » ('j') | no next file with comments »