Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 800983005: Revert of Omnibox Watcher: Don't Flag Incidents that are Paste+Enter (Closed)

Created:
6 years ago by Mark P
Modified:
6 years ago
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Omnibox Watcher: Don't Flag Incidents that are Paste+Enter (patchset #5 id:80001 of https://codereview.chromium.org/795343002/) Reason for revert: causes crashes in official builders. ../../chrome/browser/rlz/rlz_unittest.cc:240:14:error: no matching constructor for initialization of 'OmniboxLog' OmniboxLog dummy(base::string16(), false, metrics::OmniboxInputType::INVALID, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../chrome/browser/omnibox/omnibox_log.h:22:3: note: candidate constructor not viable: requires 13 arguments, but 12 were provided OmniboxLog( ^ ../../chrome/browser/omnibox/omnibox_log.h:21:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 12 were provided struct OmniboxLog { ^ 1 error generated. Original issue's description: > Omnibox Watcher: Don't Flag Incidents that are Paste+Enter > > The code currently excludes paste-and-go operations. It should probably > also exclude paste+enter operations; these are effectively equivalent. > > TODO before submitting: test interactively > > BUG= > TBR=bauerb@chromium.org > > Committed: https://crrev.com/c281fb257d2acdd247b0692380d084863e2dd462 > Cr-Commit-Position: refs/heads/master@{#308233} TBR=pkasting@chromium.org,grt@chromium.org,bauerb@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/58784d83d3c8c6ad72942e5ca8df66d27684edce Cr-Commit-Position: refs/heads/master@{#308256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/omnibox/omnibox_log.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/omnibox/omnibox_log.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/omnibox_watcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark P
Created Revert of Omnibox Watcher: Don't Flag Incidents that are Paste+Enter
6 years ago (2014-12-13 05:53:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800983005/1
6 years ago (2014-12-13 05:54:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-13 05:55:16 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-13 05:56:14 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58784d83d3c8c6ad72942e5ca8df66d27684edce
Cr-Commit-Position: refs/heads/master@{#308256}

Powered by Google App Engine
This is Rietveld 408576698