Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 800953002: Fix bug where app name is wrong in all languages except English. (Closed)

Created:
6 years ago by newt (away)
Modified:
6 years ago
Reviewers:
cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bug where app name is wrong in all languages except English. The "app_name" string needs to be defined in an Android resources XML file instead of in android_chrome_strings.grd so the string isn't copied into every language (which makes it impossible to override the string from a single strings.xml file) BUG=441424 Committed: https://crrev.com/9f03ba31407bbb0ccb395a0a1fc452685001f70b Cr-Commit-Position: refs/heads/master@{#308189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
A chrome/android/java/res/values/app_name.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/shell/java/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/shell/res/values/strings.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL yay resources!
6 years ago (2014-12-12 19:05:28 UTC) #2
cjhopman
lgtm
6 years ago (2014-12-12 21:57:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800953002/1
6 years ago (2014-12-12 22:01:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 23:09:57 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 23:10:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f03ba31407bbb0ccb395a0a1fc452685001f70b
Cr-Commit-Position: refs/heads/master@{#308189}

Powered by Google App Engine
This is Rietveld 408576698