Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 800933003: Revert of Rebase PythonCheckerTest results after upgrade to pylint 1.4.0. (Closed)

Created:
6 years ago by enne (OOO)
Modified:
6 years ago
Reviewers:
Dirk Pranke, dcheng
CC:
blink-reviews, pdr., Raymond Toy, vapier
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Rebase PythonCheckerTest results after upgrade to pylint 1.4.0. (patchset #1 id:1 of https://codereview.chromium.org/795353004/) Reason for revert: Causes test-webkitpy errors: File "third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python_unittest.py", line 63, in test_check (4, "pylint/E0602(undefined-variable)", 5, "[] Undefined variable 'error'"), AssertionError: Lists differ: [(4, 'pep8/W291', 5, 'trailing... != [(4, 'pep8/W291', 5, 'trailing... Original issue's description: > Rebase PythonCheckerTest results after upgrade to pylint 1.4.0. > > BUG= > R=dpranke@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186994 TBR=dpranke@chromium.org,dcheng@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Tools/Scripts/webkitpy/style/checkers/python_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
enne (OOO)
Created Revert of Rebase PythonCheckerTest results after upgrade to pylint 1.4.0.
6 years ago (2014-12-12 19:19:58 UTC) #1
enne (OOO)
6 years ago (2014-12-12 19:24:09 UTC) #4
Hmm, oops.  I'm super mistaken here.

Powered by Google App Engine
This is Rietveld 408576698